influxdata / influxdata/pbjson
Fully Qualify Standard Library Types in Generated Code
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 116
- Forks
- 55
- PR merge metrics
- No merged PRs in 30d
Description
The generated code does not consistently fully qualify all standard library types - in particular there are non-fully qualified `Vec`, `Result` and partially qualifies `std::collections::BTreeMap`.
This is liable to result in name collisions with the generated code, or other types which may be in scope.
All types should be fully qualified, e.g. `::std::vec::Vec`
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the generator for the serde implementations and inspect how standard library types are emitted in generated Rust code. Check the handling of Vec, Result, and std::collections::BTreeMap, then verify that every standard library type is fully qualified, including the ::std::vec::Vec form described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100