calcThroughput crashing?

Open

#1,671 opened on Nov 12, 2017 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language: Go
Stars: 2.4k
Forks: 479
Avg merge: 4d 16h
Merged PRs (30d): 4

Description

bug 100% reproducible, latest git code.
While running batch live replay, server is crashing with this message:

```
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: github.com/influxdata/kapacitor.(*node).start.func1(0xc42037e000, 0x0, 0x0, 0x0)
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: /home/ubuntu/go/src/github.com/influxdata/kapacitor/node.go:181 +0x8e
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: created by github.com/influxdata/kapacitor.(*node).start
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: /home/ubuntu/go/src/github.com/influxdata/kapacitor/node.go:159 +0x5d
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: goroutine 5137 [select]:
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: github.com/influxdata/kapacitor.(*QueryNode).runBatch(0xc420884f20, 0x0, 0x0, 0x0, 0xc4205
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: /home/ubuntu/go/src/github.com/influxdata/kapacitor/batch.go:372 +0x282
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: github.com/influxdata/kapacitor.(*QueryNode).(github.com/influxdata/kapacitor.runBatch)-fm
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: /home/ubuntu/go/src/github.com/influxdata/kapacitor/batch.go:151 +0x48
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: github.com/influxdata/kapacitor.(*node).start.func1(0xc420884f20, 0x0, 0x0, 0x0)
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: /home/ubuntu/go/src/github.com/influxdata/kapacitor/node.go:181 +0x8e
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: created by github.com/influxdata/kapacitor.(*node).start
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: /home/ubuntu/go/src/github.com/influxdata/kapacitor/node.go:159 +0x5d
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: goroutine 5156 [select]:
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: github.com/influxdata/kapacitor.(*ExecutingTask).calcThroughput(0xc4204bcbd0)
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: /home/ubuntu/go/src/github.com/influxdata/kapacitor/task.go:428 +0x2c8
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: created by github.com/influxdata/kapacitor.(*ExecutingTask).start
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: /home/ubuntu/go/src/github.com/influxdata/kapacitor/task.go:231 +0x155
Nov 12 18:14:05 ip-172-31-21-11 kapacitord[20240]: goroutine 5187 [select]:
Nov 12 18:14:06 ip-172-31-21-11 systemd[1]: kapacitor.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Nov 12 18:14:06 ip-172-31-21-11 systemd[1]: kapacitor.service: Unit entered failed state.
Nov 12 18:14:06 ip-172-31-21-11 systemd[1]: kapacitor.service: Failed with result 'exit-code'.
Nov 12 18:14:06 ip-172-31-21-11 systemd[1]: kapacitor.service: Service hold-off time over, scheduling restart.
Nov 12 18:14:06 ip-172-31-21-11 systemd[1]: Stopped Time series data processing engine..
Nov 12 18:14:06 ip-172-31-21-11 systemd[1]: Started Time series data processing engine..
```

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Research direction

The report points to task.go:428 in ExecutingTask.calcThroughput, with related batch.go:372 and node.go:181 stack frames. Start by reproducing batch live replay and tracing calcThroughput; done means the crash is explained, fixed, and covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack: go
Domain: backend, data-engineering
Issue type: Bug
Difficulty: 4/5
Estimated time: 3-5 days
Activity status: Stale
Clarity: Needs clarification
Newbie friendliness: 30/100