influxdata / influxdata/influxdb

Store triggers by `DbId` and `TriggerId` instead of name

Open
#26,153 0 comments 0 reactions 0 assignees View on GitHub
v3 v3-processing-engine
Dominant language
Rust
Stars
31.7k
Forks
3.7k
Avg merge
13h 37m
Merged PRs (30d)
8

Description

### Problem

The `ProcessingEngineManagerImpl` stores triggers maps that use `String` names for databases and triggers:

https://github.com/influxdata/influxdb/blob/1f9849be83c4393e113a0846859b544c2452c77e/influxdb3_processing_engine/src/lib.rs#L55-L63

### Proposed solution

* Change to using the `DbId` and `TriggerId` that identify these resources in the catalog.
* Methods that [start](https://github.com/influxdata/influxdb/blob/1f9849be83c4393e113a0846859b544c2452c77e/influxdb3_processing_engine/src/lib.rs#L362)/[stop](https://github.com/influxdata/influxdb/blob/1f9849be83c4393e113a0846859b544c2452c77e/influxdb3_processing_engine/src/lib.rs#L456) triggers should use these IDs as arguments instead of the names.

Contributor guide

Open the contributing guide

Research direction

Start in influxdb3_processing_engine/src/lib.rs at the trigger maps around lines 55-63, then inspect the start and stop methods linked in the issue and their callers. Update the trigger storage and method arguments to use DbId and TriggerId; done means these paths identify resources by catalog IDs rather than names.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend, databases
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.