influxdata / influxdata/influxdb

Remove snafu from dependencies in favor of thiserror

Open
#25,753 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

v3
Dominant language
Rust
Stars
31.7k
Forks
3.7k
Avg merge
13h 37m
Merged PRs (30d)
8

Description

> Would be nice if we could factor out `snafu` since we use `thiserror` everywhere else, but that can be done later.

_Originally posted by @hiltontj in https://github.com/influxdata/influxdb/pull/25737#discussion_r1902241405_

As part of #25737 we introduced a dependency as part of moving parts of clap_blocks into the influxdb3_clap_blocks crate. This was just to move what we needed in without too many changes. We should change over to this thiserror and remove our dependency on snafu

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the changes from #25737 and the influxdb3_clap_blocks crate to locate the introduced snafu dependency and its uses. Replace those uses with thiserror, remove snafu from the crate dependencies, and run the crate's relevant tests to verify the migration.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.