Flaky Annotation Tests

Open

#23,272 opened on Apr 13, 2022 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language: Rust
Stars: 31.7k
Forks: 3.7k
Avg merge: 13h 37m
Merged PRs (30d): 8

Description

These tests are flaky, passing and failing on the same code base.

```
Failed
=== RUN TestAnnotationsCRUD/select_with_filters/start_time_will_filter_out_annotations
service_test.go:315:
Error Trace: service_test.go:996
service_test.go:315
Error: Not equal:
expected: 2
actual : 4
Test: TestAnnotationsCRUD/select_with_filters/start_time_will_filter_out_annotations
--- FAIL: TestAnnotationsCRUD/select_with_filters/start_time_will_filter_out_annotations (0.00s)
```
```
Failed
=== RUN TestAnnotationsCRUD/select_with_filters/time_can_filter_out_all_annotations_if_it's_too_narrow
service_test.go:315:
Error Trace: service_test.go:996
service_test.go:315
Error: Not equal:
expected: 0
actual : 2
Test: TestAnnotationsCRUD/select_with_filters/time_can_filter_out_all_annotations_if_it's_too_narrow
--- FAIL: TestAnnotationsCRUD/select_with_filters/time_can_filter_out_all_annotations_if_it's_too_narrow (0.00s)
```

Full context https://app.circleci.com/pipelines/github/influxdata/influxdb/27973/workflows/b691447e-e89c-4c15-8b06-157ecdbec478/jobs/251520/tests#failed-test-1

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Research direction

Start with the failing tests in service_test.go, especially TestAnnotationsCRUD/select_with_filters and the referenced lines 315 and 996. Reproduce the failures using the CircleCI context and inspect why the expected annotation counts vary; done means these tests pass reliably on the same code base.

Written by the indexing model from the issue text.

Assessment

Tech stack: go
Domain: databases, testing-qa
Issue type: Bug
Difficulty: 3/5
Estimated time: 1-2 days
Activity status: Stale
Clarity: Needs clarification
Newbie friendliness: 30/100