influxdata / influxdata/influxdb
"storage-compact-throughput-burst" cannot be set lower than default of 48mb
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 31.7k
- Forks
- 3.7k
- Avg merge
- 13h 37m
- Merged PRs (30d)
- 8
Description
Our system is experiencing high load during the compaction process due to IO load. We've identified that the culprit is the background compaction process, whics run often due to our data often being written back into the past. We've lowered the max amount of concurrent compactions, but would still be able to set the throughput of the compaction process.
Since v2 CompactThroughput is no longer configurable and it defaults to 48mb. storage-compact-throughput-burst is overridden by the default of CompactThroughput during startup if set to lower than the 48mb.
So in effect, users aren't able limit compaction disk write bursts to lower than 48mb.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in tsdb/store.go around lines 264-278, as linked in the issue, and trace how storage-compact-throughput-burst is handled during startup. Confirm the behavior with a value below 48mb; done means the configured lower throughput is preserved rather than overridden by the default CompactThroughput.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- databases, performance
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100