influxdata / influxdata/influxdb

kit/cli helpers silently drop config/env variables that can't be parsed to the expected type

Open
#20,492 0 comments 0 reactions 0 assignees View on GitHub
area/2.x area/cli kind/bug
Dominant language
Rust
Stars
31.7k
Forks
3.7k
Avg merge
13h 37m
Merged PRs (30d)
8

Description

This behavior can cause user frustration when `influxd` seemingly ignores user inputs, and it's especially dangerous since there's no visible signal when it happens.

Instead of silently dropping bad config/env, we should fail fast. This will need to be clearly communicated in the release notes so users who have had bad config floating around know what's going on after they upgrade and start seeing failures.

NOTE: This might be cleaner to do after #20491

Contributor guide

Open the contributing guide

Research direction

Start by tracing the kit/cli helpers responsible for parsing configuration and environment variables, and review the dependency on issue #20491. Confirm the current behavior for values that cannot be parsed, then make failures visible and update the release notes to communicate the change.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend, cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.