influxdata / influxdata/influxdb
Integration Testing: time machine executeQueries
- Dominant language
- Rust
- Stars
- 31.7k
- Forks
- 3.7k
- Avg merge
- 13h 37m
- Merged PRs (30d)
- 8
Description
#### Background
[`executeQueries`](https://github.com/influxdata/influxdb/blob/master/ui/src/timeMachine/actions/queries.ts#L115-L239) is a great candidate to write integration tests. The main value in this test lies in `executeQueries`'s explicit dependency on `runQuery` [here,](https://github.com/influxdata/influxdb/blob/master/ui/src/timeMachine/actions/queries.ts#L153-L166) and [here,](https://github.com/influxdata/influxdb/blob/master/ui/src/timeMachine/actions/queries.ts#L168) and the implicit dependencies [here,](https://github.com/influxdata/influxdb/blob/master/ui/src/timeMachine/actions/queries.ts#L189-L216) [here,](https://github.com/influxdata/influxdb/blob/master/ui/src/timeMachine/actions/queries.ts#L218) and [here.](https://github.com/influxdata/influxdb/blob/master/ui/src/timeMachine/actions/queries.ts#L220)
Add tests for these cases will make changes to `runQuery` much easier to do with confidence.
#### Acceptance Criteria
- [ ] The explicit dependencies `executeQueries` has on `runQuery` are tested
- [ ] [query pending results loop](https://github.com/influxdata/influxdb/blob/master/ui/src/timeMachine/actions/queries.ts#L153-L166)
- [ ] [resolving promises](https://github.com/influxdata/influxdb/blob/master/ui/src/timeMachine/actions/queries.ts#L168)
- [ ] [rejecting promises](https://github.com/influxdata/influxdb/blob/master/ui/src/timeMachine/actions/queries.ts#L230-L237)
- [ ] The implicit dependencies of executeQueries` on `runQuery` are tested
- [ ] [results loop](https://github.com/influxdata/influxdb/blob/master/ui/src/timeMachine/actions/queries.ts#L189-L216)
- [ ] [csv mapping of files](https://github.com/influxdata/influxdb/blob/master/ui/src/timeMachine/actions/queries.ts#L218)
- [ ] [dispatching files](https://github.com/influxdata/influxdb/blob/master/ui/src/timeMachine/actions/queries.ts#L220)
Contributor guide
Assessment
This issue has not been assessed yet.