influxdata / influxdata/influxdb
Handle ReadHints pushed down by prometheus remote read
@dgnorton is already working on this.
Since Apr 13, 2020.
- Dominant language
- Rust
- Stars
- 31.7k
- Forks
- 3.7k
- Avg merge
- 13h 37m
- Merged PRs (30d)
- 8
Description
__Proposal:__
Make use of pushed-down ReadHints to speed up prometheus remote read query
__Current behavior:__
InfluxDB 1.x has support for prometheus remote read/write, but historically to avoid dependency it copied protobuf definition(from https://github.com/influxdata/influxdb/pull/8784).
The remote-read pb message contains label matcher and time range and that is used to filter influxdb points. But the current prometheus version has added more fields to the pb message, including ReadHints. The read hints may be used by remote storage to do more filtering and return less data.
Also the new-added streamed response type can mitigate memory usage-for now it needs to hold the whole result set in memory.
__Desired behavior:__
InfluxDB may make use of the ReadHint and handles prometheus query locally.
__Alternatives considered:__
n/a
__Use case:__
For users who use InfluxDB as prometheus remote storage, the pushed-down hints will avoid large data transformation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.