influxdata / influxdata/influxdb

Please reconsider forking httprouter

Open
#16,695 2 comments 0 reactions 1 assignee View on GitHub

@GeorgeMac is already working on this.

Since Feb 12, 2020.

dependencies
Dominant language
Rust
Stars
31.7k
Forks
3.7k
Avg merge
13h 37m
Merged PRs (30d)
8

Description

Back in https://github.com/influxdata/influxdb/commit/3dbb9c0fd2d8423a6116c3106e60fff23a6faeec you decided to fork julienschmidt/httprouter to influxdata/httprouter . I'd like you to reconsider forking project like this and move your changes upstream as much as possible. This fork will likely not be taken care off and will be cut from upstream updates and potential security fixes.

You already have forked this project before and it was never updated anymore: github.com/bouk/httprouter

So now you have 2 forks of the same project to add a single feature, which will never benefit from upstream updates.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.