influxdata / influxdata/influxdb
Refactor `updateCheck` implementation to consolidate like functions
- Dominant language
- Rust
- Stars
- 31.7k
- Forks
- 3.7k
- Avg merge
- 13h 37m
- Merged PRs (30d)
- 8
Description
### Problem
`updateCheck` was removed in the following PR:
https://github.com/influxdata/influxdb/pull/16333
in order to refactor the way the functionality was implemented. However, the linter never returned an error that the `updateCheck` was still in use here:
https://github.com/influxdata/influxdb/blob/master/ui/src/alerting/components/CheckCard.tsx#L17
As a result, the function was readded to the actions.
The problem we need to resolve is to update the functionality of the existing functions to make `updateCheck` redundant.
Contributor guide
Research direction
Start with ui/src/alerting/components/CheckCard.tsx at the referenced use of updateCheck, then inspect the existing alerting actions and PR 16333. Trace the overlapping functions and consolidate their behavior so updateCheck is no longer needed, while preserving the check update flow. Confirm the UI still uses the remaining action path and that updateCheck has no references.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100