influxdata / influxdata/influxdb
Add coarser grained retention check metrics
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 31.7k
- Forks
- 3.7k
- Avg merge
- 13h 37m
- Merged PRs (30d)
- 8
Description
Currently we track retention metrics by org, bucket etc.
I would like some extra metrics that don't include org_id or bucket_id.
It will make it easier to aggregate the metrics. Considering other metrics where we have done this, idiomatic field names for these new metrics would probably be: EngineChecks and EngineChecksDuration. Metric names probably storage_retention_engine_checks_total and storage_retention_engine_check_duration_seconds.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at storage/metrics.go lines 42-73, where the existing retention metrics are defined, and compare the current org- and bucket-scoped fields with the requested aggregate metrics. Done means exposing EngineChecks and EngineChecksDuration with the names storage_retention_engine_checks_total and storage_retention_engine_check_duration_seconds, without org_id or bucket_id.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100