influxdata / influxdata/helm-charts
helm (telegraf): add {{ .Release.Namespace }} for kustomize v5.8[01] compat
- Dominant language
- Mustache
- Stars
- 257
- Forks
- 347
- Avg merge
- 4d 20h
- Merged PRs (30d)
- 9
Description
### Description
* ArgoCD v3.3 has updated to [kustomize v5.8.0](https://argo-cd.readthedocs.io/en/stable/operator-manual/upgrading/3.2-3.3/#kustomize-upgraded-to-580)
* kustomize v5.8.0 has changed the way kustomize handles `helmCharts`: https://github.com/kubernetes-sigs/kustomize/pull/5940 which has a nice tl;dr:
```
TL;DR
If you use Kustomize with Helm charts, ensure that your Helm templates explicitly set the namespace, for example:
metadata:
namespace: {{ .Release.Namespace }}
If your charts already handle namespaces this way, this change should not introduce any breaking behavior.
```
Similar issues:
*
*
*
### Expected Behavior
using `kustomize build --enable-helm .` renders the manifests using the proper namespaces; otherwise (when used within argocd), they might land in the default namespace (=`argocd`)
Contributor guide
Research direction
Start by locating the Telegraf chart templates that render resources and checking how they set namespaces. Run `kustomize build --enable-helm .` with the chart and verify that rendered manifests use the intended release namespace rather than the default namespace.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, kubernetes
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100