influxdata / influxdata/helm-charts

Telegraf helm charts PodDisruptionBudgets don't make sense

Open
#623 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Mustache
Stars
257
Forks
347
Avg merge
4d 20h
Merged PRs (30d)
9

Description

By default, the telegraf deployments have 1 replica and a PDB of `MinAvailable: 1`, this makes the pods unevictable and scaling down kubernetes nodes not possible.
I would suggest changing `pdb: create:` to false as the default in `helm-charts/charts/telegraf/values.yaml`

See here:
> If you set maxUnavailable to 0% or 0, or you set minAvailable to 100% or the number of replicas, you are requiring zero voluntary evictions. When you set zero voluntary evictions for a workload object such as ReplicaSet, then you cannot successfully drain a Node running one of those Pods. If you try to drain a Node where an unevictable Pod is running, the drain never completes. This is permitted as per the semantics of PodDisruptionBudget.

https://kubernetes.io/docs/tasks/run-application/configure-pdb/

Contributor guide

Open the contributing guide

Research direction

Start in helm-charts/charts/telegraf/values.yaml and inspect the default pdb.create setting alongside the chart's one-replica deployment behavior. Done means the default no longer creates an unevictable PodDisruptionBudget for the default configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes
Domain
devops, infrastructure
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.