influxdata / influxdata/giraffe
Visualization: TableLayer: update interface to avoid double parsing
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 189
- Forks
- 33
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 4
Description
The way it is now:
Some applications that consume Giraffe will do the parsing of a fluxResponse as part of the response handling prior to any interaction with Giraffe. For such applications, rendering a TableLayer through Giraffe means re-sending the fluxResponse to Giraffe, which in turn parses it slightly differently for TableLayer to consume. Thus, there is double parsing. This is very costly for ui performance.
Proposal:
Avoid double parsing. Giraffe's config interface should allow TableLayer to optionally accept another data property to avoid double parsing.
Considerations:
Keep TableLayer backwards compatible by continuing to allow it to use fluxResponse. This is for open source users.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Giraffe config interface and TableLayer handling for fluxResponse. Trace how parsed data reaches TableLayer, then define the backward-compatible optional data property and verify that existing fluxResponse users still work without double parsing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- data-visualization
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100