influxdata / influxdata/giraffe

Hover Dimension: empty string for Band Plot

Open
#705 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

documentation kind/feature request team/dumplings team/ui
Dominant language
TypeScript
Stars
189
Forks
33
Avg merge
3d 15h
Merged PRs (30d)
4

Description

Previously, an empty string for the hoverDimension property in Band Plot's config would produce behavior unlike any other valid choice for hoverDimension. See the video below. This option has been removed from the storybook examples.

Is empty string considered a valid hoverDimension? And if so, then the behavior and option should be documented.

https://user-images.githubusercontent.com/10736577/142072120-d13f05ac-6ccb-4dd5-b138-ccc0392d82c5.mp4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Band Plot storybook examples and the hoverDimension configuration referenced in the issue. Reproduce the empty-string behavior shown in the video, compare it with the other valid hoverDimension choices, and determine whether the option should be supported and documented or removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
data-visualization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.