influxdata / influxdata/giraffe
Line graph shading should not be limited to just vertical shading
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 189
- Forks
- 33
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 4
Description
Line graph shading is very primitive and needs improvement. The "shadeBelow" option is very literal. It does not care that a line graph can be flipped sideways (time as the y-axis, value as the x-axis).
Proposal: "shadeBelow" should be smarter: allow the user to specify the shaded dimension, and have sensible defaults that follows the time axis by shading appropriately.
Here is an example of incorrect shading when time axis is flipped with the value axis:
The correct shading would be shading that goes from the vertical axis' border on the left to the line points, ie left-to-right shading.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the line graph implementation and the shadeBelow option, then reproduce the sideways time/value-axis case shown in the issue. Done means users can specify the shaded dimension and the default follows the time axis, producing left-to-right shading when the axes are flipped.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- data-visualization
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100