influxdata / influxdata/giraffe
Lint: best practices / fix all warnings
Open
Nobody has claimed this yet.
kind/tech debt
team/dumplings
team/ui
- Dominant language
- TypeScript
- Stars
- 189
- Forks
- 33
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 4
Description
Fix all lint warnings. Most, if not all of them, are related to React hooks. Fix the warnings as appropriate.
- in the terminal, run
yarn lintto get a list of warnings - fixing a warning may also include disabling a particular rule for that line of code if the rule does not make sense for the purpose of the code. For example, this is applicable to React hook warnings on exhaustive dependencies, which may not always be necessary
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Run yarn lint in the repository and review the complete warning list, paying particular attention to React hooks and exhaustive-dependencies warnings. For each warning, make the appropriate correction or disable the rule only when it does not fit the code's purpose. Done means the lint warnings reported by yarn lint are resolved or intentionally suppressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100