influxdata / influxdata/giraffe
Investigate eslint consitency between giraffe and clockface and influx
- Dominant language
- TypeScript
- Stars
- 189
- Forks
- 33
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 4
Description
https://github.com/influxdata/giraffe/pull/130#pullrequestreview-328519171
To fix security vulnerabilities, I turned off `no empty functions` due to a lint failure. I believe this failure occurred in a test, so it might just be a matter of commenting an exception. Either way, this issue was created so we could push out critical fixes first and deal with a linting tweak later.
Contributor guide
Research direction
Start with the linked pull request review and inspect the ESLint change that disabled no-empty-functions after the security fixes. Compare the relevant lint behavior in giraffe with clockface and influx, then identify the affected test or lint configuration. Done means the consistency issue is resolved without reintroducing the reported lint failure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- eslint, typescript
- Domain
- testing, tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100