infinyon / infinyon/node-bindgen

Safety mistake? when calling binding function

Open
#232 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
587
Forks
43
PR merge metrics
No merged PRs in 30d

Description

Shouldn't this be marked `unsafe`? https://github.com/infinyon/node-bindgen/blob/952a08a07b4438a1f1a71b4d0c4937c7d9b61dd2/nj-core/src/basic.rs#L328

If it call this with a null pointer or something like that, it is ub?

Contributor guide

Open the contributing guide

Research direction

Start at nj-core/src/basic.rs:328 and inspect the binding function and its pointer-safety assumptions. Check how callers invoke it and whether existing tests cover invalid or null pointers; done means the safety contract and resulting behavior are explicitly established and verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, rust
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.