infinyon / infinyon/node-bindgen
fix CI for windows
- Dominant language
- Rust
- Stars
- 587
- Forks
- 43
- PR merge metrics
- No merged PRs in 30d
Description
Regression introduced in: https://github.com/infinyon/node-bindgen/pull/197.
https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true.
```
error: failed to run custom build command for `nj-example-function v0.0.0 (D:\a\node-bindgen\node-bindgen\examples\function)`
[587](https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true#step:8:588)
[588](https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true#step:8:589)
Caused by:
[589](https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true#step:8:590)
process didn't exit successfully: `D:\a\node-bindgen\node-bindgen\examples\target\debug\build\nj-example-function-4b753c1df0bfd246\build-script-build` (exit code: 101)
[590](https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true#step:8:591)
--- stdout
[591](https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true#step:8:592)
downloading nodejs: https://nodejs.org/dist/v16.15.1
[592](https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true#step:8:593)
/win-x64/node.lib to: "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\node-v16.15.1.lib"
[593](https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true#step:8:594)
[594](https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true#step:8:595)
--- stderr
[595](https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true#step:8:596)
thread 'main' panicked at 'Download node.lib file failed: Parse(StatusErr)', D:\a\node-bindgen\node-bindgen\nj-build\src\lib.rs:35:14
[596](https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true#step:8:597)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[597](https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true#step:8:598)
warning: build failed, waiting for other jobs to finish...
[598](https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true#step:8:599)
mingw32-make[2]: *** [makefile:4: build] Error 101
[599](https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true#step:8:600)
mingw32-make[2]: Leaving directory 'D:/a/node-bindgen/node-bindgen/examples/function'
[600](https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true#step:8:601)
mingw32-make[1]: *** [makefile:25: test-function] Error 2
[601](https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true#step:8:602)
mingw32-make[1]: Leaving directory 'D:/a/node-bindgen/node-bindgen/examples'
[602](https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true#step:8:603)
mingw32-make: *** [makefile:18: test-examples] Error 2
[603](https://github.com/infinyon/node-bindgen/runs/7245525951?check_suite_focus=true#step:8:604)
Error: Process completed with exit code 1.
```
Contributor guide
Research direction
Start with the linked Windows CI run and inspect nj-build/src/lib.rs around line 35, where the node.lib download failure is reported. Compare the behavior with the regression introduced by pull request 197 and rerun the Windows examples workflow. Done means the Windows CI examples build completes successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js, rust
- Domain
- build-system, ci-cd
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100