infinyon / infinyon/node-bindgen
build::configure() should not put node-vX.Y.Z.lib in %LocalAppData%\Temp
- Dominant language
- Rust
- Stars
- 587
- Forks
- 43
- PR merge metrics
- No merged PRs in 30d
Description
- First of all this has the potential to break CI builds in surprising ways (if temp dir is cleaned before each build)
- It leads to the linker flag "/LIBPATH:C:\\Users\\\\AppData\\Local\\Temp\\" which has all kinds of interesting security implications
- It might clash with other projects using the temp dir
- Other projects (napi_rs, for instance) use OUT_DIR to store the lib
I can do a pull request if you want.
Contributor guide
Research direction
Start by locating the build::configure() entry point and read how it chooses the temporary directory and constructs the linker path on Windows. Compare the reported OUT_DIR approach used by other projects, then verify that the generated library is kept outside the shared temp directory and that builds no longer emit the reported %LocalAppData%\Temp linker path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js, rust
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100