infinitered / infinitered/reactotron
Add `id` key to plugins and add to connection info
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 15.6k
- Forks
- 972
- PR merge metrics
- No merged PRs in 30d
Description
Currently in `reactotron-core-client`, we keep track of what plugins are loaded:
https://github.com/infinitered/reactotron/blob/master/lib/reactotron-core-client/src/reactotron-core-client.ts#L184
However, we do not have the names of the plugins that are loaded: just the features and callbacks.
When we call `.connect()`, we send information about the connection over to `reactotron-app`
https://github.com/infinitered/reactotron/blob/master/lib/reactotron-core-client/src/reactotron-core-client.ts#L291-L297
We should add `id` as a field to plugins with their name so that `reactotron-app` can be customized based on what plugins are configured in the client. This would unblock this issue https://github.com/infinitered/reactotron/issues/1345#issuecomment-1856269783
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/reactotron-core-client/src/reactotron-core-client.ts at the plugin tracking around line 184 and the connection payload around lines 291-297. Trace how plugins are registered and how connection information is sent to reactotron-app. Done means plugin connection data includes each plugin's id so the app can identify configured plugins.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- developer-experience
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100