infinitered / infinitered/reactotron

Except for redux-saga

Open
#1,191 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
15.6k
Forks
972
PR merge metrics
No merged PRs in 30d

Description

Hi, thanks for the amazing tool!

There is one issue that I want to address.

For some reason the `except` option in `sagaPlugin` doesn't actually ignore sagas. However, the `except` option in `reactotronRedux` ignores the actions.

Why wouldn't `except` option in `sagaPlugin` work? If the action name wasn't correct, then it wouldn't ignore the actions from `reactotronRedux`, right?

```js
const exceptActions = [
'session/addPeak'
];

const reactotron = Reactotron.configure({ host }).useReactNative()
.setAsyncStorageHandler!(AsyncStorage)
.use(reactotronRedux({ except: exceptActions }))
.use(sagaPlugin({ except: exceptActions }))
.connect();
```

Thank you!

Contributor guide

Open the contributing guide

Research direction

Start at the sagaPlugin and reactotronRedux entry points, using the provided exceptActions example to reproduce the mismatch. Trace how each plugin handles the action name and verify the behavior with a matching saga action. Done means sagaPlugin ignores the same action names that reactotronRedux excludes.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, redux, typescript
Domain
devtools, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.