infinitered / infinitered/bluepotion

PMListScreen table_data return value

Open
#63 6 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
Ruby
Stars
74
Forks
18
PR merge metrics
No merged PRs in 30d

Description

This is just for discussion.

On iOS, the return value for `table_data` is an `[]` of sections. Each containing `{cells:[]}` to get to the goods. Make sense.

On Android, we have the same interface, but we don't have sections over here, so I feel like the interface isn't quite right.

Our current implementation says `[]` -> `PMBaseAdapter` and `{adapter: ...}` -> `PMCursorAdapter`.

It'd be super cool if `{cells: []}` could invoke the base adapter too.

I'm creating a lot of `[{cells: cells}]` return values from my `table_data` screens. It'd be nice if it were just `{cells: cells}` or even just `[{cell 1},{cell2}]`.

Just wanted to throw it out there because sections won't be a native thing on Android.

Holy crap this is so not a big deal. I'm cool with a `wontfix` label of shame. Just my $0.02 (Canadian).

Contributor guide

Open the contributing guide

Research direction

Review the PMListScreen table_data contract and the PMBaseAdapter and PMCursorAdapter paths mentioned in the issue; no file or test is identified. Before implementation, establish the desired Android return shape and completion criteria with maintainers.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, ruby
Domain
mobile-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.