infinispan / infinispan/protostream
@ProtoName ignored by proto.lock checks
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 56
- Forks
- 39
- Avg merge
- 5h 36m
- Merged PRs (30d)
- 5
Description
Consider a standalone class Example which is present in a generated proto.lock file. If this class is moved to a subclass, say Parent.Example, then proto.lock will continue to fail even if @ProtoName("Example") is explicitly set.
I expect that the value explicitly specified by @ProtoName would be taken into consideration here and the check would pass as the Proto type name should remain the same.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named in the issue. Start by locating the proto.lock validation and the handling of @ProtoName, then reproduce the move from Example to Parent.Example with @ProtoName("Example"). Done means the proto.lock check passes when the explicit Proto type name remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100