Duplicated isValidElement from inferno-compat in inferno-router/src/utils.ts
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 16.5k
- Forks
- 640
- PR merge metrics
- No merged PRs in 30d
Description
Consider importing isValidElement from inferno-compat instead or moving isValidElement to inferno or inferno-shared and exporting it from there.
Personally I think it belongs to inferno-shared.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in inferno-router/src/utils.ts and inspect the duplicated isValidElement implementation. Compare the suggested export paths in inferno-compat, inferno, and inferno-shared, then determine the appropriate source and update the router to use it. Done means the duplicate is removed and isValidElement is imported from the chosen package.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100