indygreg / indygreg/PyOxidizer
[tugger-wix] Adding EULA rtf does not work
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 6.2k
- Forks
- 256
- PR merge metrics
- No merged PRs in 30d
Description
The WixVariable ID to add the EULA rtf has a typo, it should be `WixUILicenseRtf` and not WixUILicenseRTF`
This results in having the default lorem ipsum text in the license dialog box instead of the actual rtf text.
Typo:
https://github.com/indygreg/PyOxidizer/blob/b78b0cb75f4317c45408bbc9a569c062c482c679/tugger-wix/src/simple_msi_builder.rs#L521
Reference:
https://wixtoolset.org/docs/v3/wixui/wixui_customizations/#specifying-a-license-file
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open tugger-wix/src/simple_msi_builder.rs around line 521 and compare the WixVariable ID with the linked WiX customization reference. Correct the identifier so the EULA dialog uses the supplied RTF instead of the default lorem ipsum text, then verify the MSI license content.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100