indygreg / indygreg/PyOxidizer

`pyoxidizer run` extra args are ignored

Open
#665 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
6.2k
Forks
256
PR merge metrics
No merged PRs in 30d

Description

The PyOxidizer Getting Started docs suggest using `pyoxidizer run -- [args]`:

https://github.com/indygreg/PyOxidizer/blob/0defb06fd21c81dbde43ff8ffddd92ff133ec4c0/pyoxidizer/docs/pyoxidizer_getting_started.rst?plain=1#L330-L350

But it does not actually work. Looking at the code, `pyoxidizer run` does accept extra args, which get passed to `projectmgmt::run` as `_extra_args`:

https://github.com/indygreg/PyOxidizer/blob/0defb06fd21c81dbde43ff8ffddd92ff133ec4c0/pyoxidizer/src/projectmgmt.rs#L142-L171

However, this function does not use them so they just get lost. I looks like the regression was introduced in https://github.com/indygreg/PyOxidizer/commit/df0d459e044419369854918a03baa496d565608c released in 0.5.1. I tried to see quickly if I could fix the issue, but looks like `starlark::eval::EvaluationContextBuilder` does not support extra args at all? I don't know Rust or PyOxidizer enough to tell.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the documented `pyoxidizer run -- [args]` behavior in `pyoxidizer/docs/pyoxidizer_getting_started.rst` and trace the extra-argument handling in `pyoxidizer/src/projectmgmt.rs`. Inspect how `projectmgmt::run` invokes the Starlark evaluation context and whether `EvaluationContextBuilder` can receive arguments. Done means arguments after `--` reach the packaged application as documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.