indygreg / indygreg/PyOxidizer

starlark_tugger.glob() appears to always use / as the path separator, even on Windows

Open
#421 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Rust
Stars
6.2k
Forks
256
PR merge metrics
No merged PRs in 30d

Description

This took a while to figure out, but as far as I can tell a glob like glob(include=["C:\foo\bar\**\*"]) will never match anything, and instead would need to be expressed with forward slashes (that is, glob(include=["C:/foo/bar/**/*"])) in order to match things.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the starlark_tugger.glob() entry point and reproduce the reported include pattern on Windows, comparing backslash and forward-slash paths. Trace path-separator handling and verify that the Windows-style pattern matches the same files as its forward-slash equivalent.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
operating-systems, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.