indygreg / indygreg/PyOxidizer

Adding an empty manifest (say because a glob matched nothing) should at least be a warning

Open
#420 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Rust
Stars
6.2k
Forks
256
PR merge metrics
No merged PRs in 30d

Description

While working on making the Mercurial pyoxidizer.bzl more extensible, I had some files mysteriously not being included. After way too much debugging, I had problems in my glob() statements that were causing the imports to fail. Perhaps add_manifest(glob(...)) could warn or fail if you attempt to add an empty manifest?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the pyoxidizer.bzl usage of add_manifest(glob(...)) described in the issue, then trace how an empty manifest is handled. Decide whether the requested behavior should warn or fail, and verify that files are not silently omitted when a glob matches nothing.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.