indutny / indutny/ocsp

TimeoutOverflowWarning with large nextUpdate values

Open
#28 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
86
Forks
46
PR merge metrics
No merged PRs in 30d

Description

If the OCSP response contains a nextUpdate value that is larger than the 32-bit signed integer limit, it causes the TimeoutOverflowWarning to be triggered when caching and sets the cache timeout to 1 instead.

It should be as simple as putting an upper ceiling on the callback here https://github.com/indutny/ocsp/blob/master/lib/ocsp/cache.js#L116

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at lib/ocsp/cache.js around line 116, where the cache callback handles the nextUpdate value. Reproduce an OCSP response with a nextUpdate beyond the 32-bit signed integer limit and observe the warning and timeout behavior. Done means large values no longer trigger TimeoutOverflowWarning or reduce the cache timeout to 1.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.