indutny / indutny/node-nat-upnp
description field become an empty object if upnp port-mapping description is an empty string
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 148
- Forks
- 62
- PR merge metrics
- No merged PRs in 30d
Description
please check out description below, looks like an xml2js bug?
node-nat-upnp version 1.1.1
i think the xml2js dependency should be updated. xml2js "0.4.19" doesn't have this issue.
```
> var natUpnp = require('nat-upnp');
undefined
> var client = natUpnp.createClient();
undefined
> client.getMappings(function(err, results) { console.log(results) })
undefined
[ { public: { host: '', port: 13760 },
private: { host: '192.168.50.48', port: 1080 },
protocol: 'tcp',
enabled: true,
description: {},
ttl: 0,
local: false } ]
```
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the supplied node-nat-upnp getMappings example and inspect the package dependency on xml2js. Check whether updating that dependency changes an empty UPnP description from an object to an empty string, then verify the mapping result uses the expected description value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, nodejs
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100