indutny / indutny/node-nat-upnp
xml2js outdated -> Error: Text data outside of root node on invalid router response
- Dominant language
- JavaScript
- Stars
- 148
- Forks
- 62
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/Storj/storjshare-gui/issues/593
```
`{"level":"warn","message":"you are not publicly reachable, trying traversal strategies...","timestamp":"2017-05-17T02:46:19.905Z"}
C:\Program Files (x86)\Storj Share\resources\app\node_modules\xml2js\lib\xml2js.js:216
throw ex;
^
Error: Text data outside of root node.
Line: 78
Column: 1
Char: `
```
```
root@storj:~# npm list -g xml2js
/usr/local/lib
└─┬ storjshare-daemon@2.5.4
└─┬ storj-lib@6.4.2
└─┬ nat-upnp@1.1.0
└── xml2js@0.1.14
```
This issue was fixed in xml2js 0.4.2 https://github.com/Leonidas-from-XIV/node-xml2js/issues/118
I will work on a pull request.
Contributor guide
No contributing guide indexed for this repository
Research direction
Inspect nat-upnp's dependency declaration and the xml2js version shown in the npm tree; start by tracing how invalid router responses reach the parser. Verify the dependency update against the reported invalid response and confirm that the “Text data outside of root node” failure no longer occurs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100