indutny / indutny/node-nat-upnp
heading towards a solid v1.0
- Dominant language
- JavaScript
- Stars
- 148
- Forks
- 62
- PR merge metrics
- No merged PRs in 30d
Description
This is the direction I'm heading:
https://github.com/coolaj86/node-nat-upnp/blob/v1.0/lib/nat-upnp/ssdp.js
- switched from shimmed EventEmitter promise-ish things to proper Promises using `global.Promise || require('bluebird').Promise`
- pulled the async code out of the constructor (since you can't pass callbacks or return promises from a constructor) and moved it to an `init()`
- removed mutual dependencies
I plan to switch it to return however many IGDs respond.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by comparing the current implementation with lib/nat-upnp/ssdp.js at the linked v1.0 revision, focusing on the Promise handling, constructor versus init() flow, and mutual dependencies. Done means those changes are reflected and the implementation returns every responding IGD as described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100