inductiveautomation / inductiveautomation/ignition-sdk-examples

Changes not detected/included when building .modl from perspective-component using the newer open-sourced plugin

Open
#96 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
222
Forks
123
PR merge metrics
No merged PRs in 30d

Description

Using `./gradle zipModule` (or `./gradle build` w/dummy certificate) to build a module file, it will not detect and include changes done in `common`, `designer` or `gateway`. Only if a change has been done in `web` will a new modl file actually get created.

It will correctly generate a modl file upon first call after cloning the repo. But for subsequent calls, it does not detect that java/json files has changed.

Issue was not present in older version using `./gradle buildModule`

Could it be linked to the following issue?
https://github.com/inductiveautomation/ignition-module-tools/issues/28

On a related note:
Previously build number was added as `byyyymmddHH`, but for all builds with the newest version we only get `b0`. Is this as expected?

----

Steps to reproduce:
- Check out latest version of `perspective-component`
- Open git bash in repo on a PC running windows 10
- Run `./gradlew build` or `./gradlew zipModule` --> A .modl file gets created
- Make a change to `common/src/main/resources/*.json`
- Run `./gradlew build` or `./gradlew zipModule` --> No new .modl file will be created (unless old file was deleted manually first).

You can force it to create a modl file that actually contains the changes in `/common/src/main/resources` by deleting `/common/build` before running `./gradlew build`. This results in a new .modl file creation, that actually includes the changes made to the json file.
PS: designer does not notify that it requires restart - you must do that manually before changes can be seen.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the behavior with ./gradlew build or ./gradlew zipModule, then inspect the build outputs under common/build and the changes in common/src/main/resources/*.json. Compare the newer commands with the older ./gradlew buildModule behavior and verify that changes in common, designer, and gateway are detected and included in the generated .modl file.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.