inductiveautomation / inductiveautomation/ignition-module-tools

files overwrite warnings during assembleModlStructure

Open
#62 1 comment 0 reactions 1 assignee Claimed by @brianeray View on GitHub
Dominant language
Kotlin
Stars
73
Forks
20
PR merge metrics
No merged PRs in 30d

Description

When using the `foldJars` option,
```kotlin
tasks.writeModuleXml {
foldJars = true
}
```
, dependencies are being copied to the `build\moduleContent` folder multiple times, doing unnecessary work and creating noisy logs.

```
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\common\build\artifacts\annotations-13.0.jar' will be copied to 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\build\moduleContent\annotations-13.0.jar', overwriting file 'D:\Projects\Musson Industrial\emb
r\modules\thermo\ignition81\client\build\artifacts\annotations-13.0.jar', which has already been copied there.
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\common\build\artifacts\embr-core-ignition81-common-0.4.0.jar' will be copied to 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\build\moduleContent\embr-core-ignition81-common-0.4.0.jar', overwriting file
'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\client\build\artifacts\embr-core-ignition81-common-0.4.0.jar', which has already been copied there.
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\common\build\artifacts\embr-thermo-ignition81-common-0.1.2.jar' will be copied to 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\build\moduleContent\embr-thermo-ignition81-common-0.1.2.jar', overwriting f
ile 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\client\build\artifacts\embr-thermo-ignition81-common-0.1.2.jar', which has already been copied there.
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\common\build\artifacts\if97-2.0.0.jar' will be copied to 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\build\moduleContent\if97-2.0.0.jar', overwriting file 'D:\Projects\Musson Industrial\embr\modules\th
ermo\ignition81\client\build\artifacts\if97-2.0.0.jar', which has already been copied there.
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\common\build\artifacts\kotlin-stdlib-2.0.0.jar' will be copied to 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\build\moduleContent\kotlin-stdlib-2.0.0.jar', overwriting file 'D:\Projects\Musson Industri
al\embr\modules\thermo\ignition81\client\build\artifacts\kotlin-stdlib-2.0.0.jar', which has already been copied there.
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\designer\build\artifacts\annotations-13.0.jar' will be copied to 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\build\moduleContent\annotations-13.0.jar', overwriting file 'D:\Projects\Musson Industrial\e
mbr\modules\thermo\ignition81\client\build\artifacts\annotations-13.0.jar', which has already been copied there.
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\designer\build\artifacts\embr-core-ignition81-client-0.4.0.jar' will be copied to 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\build\moduleContent\embr-core-ignition81-client-0.4.0.jar', overwriting fil
e 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\client\build\artifacts\embr-core-ignition81-client-0.4.0.jar', which has already been copied there.
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\designer\build\artifacts\embr-core-ignition81-common-0.4.0.jar' will be copied to 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\build\moduleContent\embr-core-ignition81-common-0.4.0.jar', overwriting fil
e 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\client\build\artifacts\embr-core-ignition81-common-0.4.0.jar', which has already been copied there.
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\designer\build\artifacts\embr-thermo-ignition81-client-0.1.2.jar' will be copied to 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\build\moduleContent\embr-thermo-ignition81-client-0.1.2.jar', overwriting
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\client\build\artifacts\embr-thermo-ignition81-client-0.1.2.jar', which has already been copied there.
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\designer\build\artifacts\embr-thermo-ignition81-common-0.1.2.jar' will be copied to 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\build\moduleContent\embr-thermo-ignition81-common-0.1.2.jar', overwriting
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\client\build\artifacts\embr-thermo-ignition81-common-0.1.2.jar', which has already been copied there.
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\designer\build\artifacts\if97-2.0.0.jar' will be copied to 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\build\moduleContent\if97-2.0.0.jar', overwriting file 'D:\Projects\Musson Industrial\embr\modules\
thermo\ignition81\client\build\artifacts\if97-2.0.0.jar', which has already been copied there.
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\designer\build\artifacts\kotlin-stdlib-2.0.0.jar' will be copied to 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\build\moduleContent\kotlin-stdlib-2.0.0.jar', overwriting file 'D:\Projects\Musson Indust
rial\embr\modules\thermo\ignition81\client\build\artifacts\kotlin-stdlib-2.0.0.jar', which has already been copied there.
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\gateway\build\artifacts\annotations-13.0.jar' will be copied to 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\build\moduleContent\annotations-13.0.jar', overwriting file 'D:\Projects\Musson Industrial\em
br\modules\thermo\ignition81\client\build\artifacts\annotations-13.0.jar', which has already been copied there.
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\gateway\build\artifacts\embr-core-ignition81-common-0.4.0.jar' will be copied to 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\build\moduleContent\embr-core-ignition81-common-0.4.0.jar', overwriting file
'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\client\build\artifacts\embr-core-ignition81-common-0.4.0.jar', which has already been copied there.
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\gateway\build\artifacts\embr-thermo-ignition81-common-0.1.2.jar' will be copied to 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\build\moduleContent\embr-thermo-ignition81-common-0.1.2.jar', overwriting
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\client\build\artifacts\embr-thermo-ignition81-common-0.1.2.jar', which has already been copied there.
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\gateway\build\artifacts\if97-2.0.0.jar' will be copied to 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\build\moduleContent\if97-2.0.0.jar', overwriting file 'D:\Projects\Musson Industrial\embr\modules\t
hermo\ignition81\client\build\artifacts\if97-2.0.0.jar', which has already been copied there.
file 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\gateway\build\artifacts\kotlin-stdlib-2.0.0.jar' will be copied to 'D:\Projects\Musson Industrial\embr\modules\thermo\ignition81\build\moduleContent\kotlin-stdlib-2.0.0.jar', overwriting file 'D:\Projects\Musson Industr
ial\embr\modules\thermo\ignition81\client\build\artifacts\kotlin-stdlib-2.0.0.jar', which has already been copied there.
```

I guess could resolve this by ensuring the dependency is only listed as `modlImplementation` for a single scope, but that defeats the whole purpose of `foldJars`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.