inductiveautomation / inductiveautomation/ignition-module-tools

Provide better error message if certAlias is wrong in SignModule

Open
#60 1 comment 0 reactions 1 assignee View on GitHub

@brianeray is already working on this.

Since Sep 20, 2024.

Dominant language
Kotlin
Stars
73
Forks
20
No merged PRs in 30d

Description

Currently, if using a pfx keystore and specifying the wrong certificate alias, the keystore returns null for

val privateKey: PrivateKey = keyStore.getKey(
            certAlias,
            certPassword?.toCharArray()
        ) as PrivateKey

which then throws null cannot be cast to non-null type java.security.PrivateKey from line 360 in the SignModule.kt file, rather than informing the user that the requested alias was not found.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.