inducer / inducer/relate

Flow page data can get tangled under group changes

Open
#384 2 comments 0 reactions 0 assignees View on GitHub
bug p2 quick
Dominant language
Python
Stars
435
Forks
124
Avg merge
5h 40m
Merged PRs (30d)
14

Description

It is possible to change flow descriptions in such a way that ordinals are duplicated, leading to

```
Internal Server Error: /course/cs450-f17/flow-session/343636/29/

MultipleObjectsReturned at /course/cs450-f17/flow-session/343636/29/
get() returned more than one FlowPageData -- it returned 2!
```

with a backtrace of

```
Traceback:

File "/home/andreas/my-relate-env3/lib/python3.6/site-packages/django/core/handlers/exception.py" in inner
41. response = get_response(request)

File "/home/andreas/my-relate-env3/lib/python3.6/site-packages/django/core/handlers/base.py" in _get_response
187. response = self.process_exception_by_middleware(e, request)

File "/home/andreas/my-relate-env3/lib/python3.6/site-packages/django/core/handlers/base.py" in _get_response
185. response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "./course/utils.py" in wrapper
787. response = f(pctx, *args, **kwargs)

File "./course/flow.py" in view_flow_page
1775. request=pctx.request)

File "./course/utils.py" in __init__
723. FlowPageData, flow_session=flow_session, ordinal=ordinal)

File "/home/andreas/my-relate-env3/lib/python3.6/site-packages/django/shortcuts.py" in get_object_or_404
85. return queryset.get(*args, **kwargs)

File "/home/andreas/my-relate-env3/lib/python3.6/site-packages/django/db/models/query.py" in get
384. (self.model._meta.object_name, num)

Exception Type: MultipleObjectsReturned at /course/cs450-f17/flow-session/343636/29/
Exception Value: get() returned more than one FlowPageData -- it returned 2!
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.