inducer / inducer/pytato

Think about refactoring `NamedArrays` and its descendants

Open
#658 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
15
Forks
16
Avg merge
17m
Merged PRs (30d)
1

Description

The existing `NamedArray` and its derived types `LoopyCallResult` and `NamedCallResult` currently have some inconsistencies in their implementations, including:

* The `expr` property only applies to `NamedArray` and its associated container `DictOfNamedArrays`, not the other two types, as `LoopyCall` and `Call` don't contain corresponding arrays to point to.
* `NamedArray` and `LoopyCallResult` are allowed to be tagged, but `NamedCallResult` isn't.

This could stand to be looked at. One idea would be to try to remove `LoopyCallResult` and `NamedCallResult` and shift any special mapper logic associated with them into `map_loopy_call` and `map_call`. Then potentially `NamedArray` could be left as a dumb generic reference type with no tagging, etc. It's not completely clear to me whether this could work, but it seems worth exploring at some point.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.