inducer / inducer/pytato

Get rid of `sorted` in bindings rewrites

Open
#601 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
15
Forks
16
Avg merge
17m
Merged PRs (30d)
1

Description

In #515, @majosm asks: `# FIXME: Are these sorts still necessary?` in relation to code like this:
```py
... for name, subexpr in sorted(expr.bindings.items())}
```
I believe that we can now do without those, so we should try to get rid of them. (post #515)

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the bindings rewrites for occurrences of sorted(expr.bindings.items()) and inspect the related rewrite tests. Determine whether removing the sorts preserves the expected results, then run the affected tests; done means the unnecessary sorts are gone and the tests still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
compilers
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.