inducer / inducer/meshpy

meshpy reports gmsh failure when warnings occur

Open
#30 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
588
Forks
112
Avg merge
9h 38m
Merged PRs (30d)
2

Description

The meshpy error processing is a bit too sensitive in that it simply scans for the word 'error' in the stderr of the gmsh output (https://github.com/inducer/meshpy/blob/master/meshpy/gmsh.py#L182). This is problematic if some warning occurs during the gmsh run, which typically leads to output like this:

> Warning : ------------------------------
> Warning : Mesh generation error summary
> Warning : 6 warnings
> Warning : 0 errors
> Warning : Check the full log for details
> Warning : ------------------------------

Clearly, there was no error, but meshpy still throws a `GmshError`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.