inducer / inducer/meshmode

L2ProjectionInverseDiscretizationConnection should allow modal output

Open
#206 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
34
Forks
25
Avg merge
3h 37m
Merged PRs (30d)
2

Description

This could avoid the forced (and possibly un-needed) modal-to-nodal conversion at the end of the connection:

https://github.com/inducer/meshmode/blob/cdcc7f5e4ae883a31ac9da3629b0acd2289e2a34/meshmode/discretization/connection/projection.py#L219-L229

I *think* this is easy to do since it receives a connection as input. It just needs to check whether the output side of the connection is modal, and if so, skip the extra conversion to nodal.

I noticed this while reviewing #192.

cc @alexfikl @thomasgibson

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.