inducer / inducer/loopy

Redundant checks for not-supplied offset parameters in invoker

Open
#929 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
636
Forks
81
Avg merge
1d 19h
Merged PRs (30d)
7

Description

Visible in https://gist.github.com/matthiasdiener/b50910994b638097c37c9162f2005982, as flagged in https://github.com/illinois-ceesd/mirgecom/issues/1101. Interspersed between enqueues.

Seems like this is mostly about offset parameters.

Also:
- [ ] Incorrect error messages in those.

Example:
```py
if _actx_in_1_6_ox_mass_0_offset is None:
raise RuntimeError("input argument '{var_descr.name}' must be supplied")
if _pt_data_141_offset is None:
raise RuntimeError("input argument '{var_descr.name}' must be supplied")
if dof_pick_list_indices_10_offset is None:
raise RuntimeError("input argument '{var_descr.name}' must be supplied")
if dof_pick_list_indices_11_offset is None:
raise RuntimeError("input argument '{var_descr.name}' must be supplied")
if dof_pick_lists_10_offset is None:
raise RuntimeError("input argument '{var_descr.name}' must be supplied")
if dof_pick_lists_11_offset is None:
raise RuntimeError("input argument '{var_descr.name}' must be supplied")
if from_el_indices_16_offset is None:
raise RuntimeError("input argument '{var_descr.name}' must be supplied")
```

cc @matthiasdiener

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.