inducer / inducer/grudge

WADG should use overintegration

Open
#173 2 comments 0 reactions 1 assignee Claimed by @thomasgibson View on GitHub
Dominant language
Python
Stars
14
Forks
18
Avg merge
26m
Merged PRs (30d)
1

Description

@thomasgibson pointed out that our WADG could/should be able to take advantage of overintegration, which it currently doesn't. Consider the matrix we're supposed to apply:

![image](https://user-images.githubusercontent.com/352067/137021698-ec2221fc-c9d6-4c3a-8e3b-e4757c3560fe.png)

(From [the paper](https://arxiv.org/pdf/1608.03836.pdf#page=6)) Consider the current implementation:

https://github.com/inducer/grudge/blob/2af3528391bf4cb07f5aacf43f7c6afcc18f693a/grudge/op.py#L645-L653

The `ref_Minv * ref_M * (1/jac_det) * ref_Minv * u` shold really be (in weird pseudocode):

```
ref_Minv * ref_M("overintegrated") * (1/project("overintegrated", jac_det) * project("overintegrated", ref_Minv * u)
```

cc @lukeolson

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.