indieweb / indieweb/mention-client-php

discoverWebmentionEndpoint returns nothing if link (in HTML) not enclosed in quotes

Open
#38 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
105
Forks
22
PR merge metrics
No merged PRs in 30d

Description

I've got this case where an endpoint ( `` in the page's HTML) is not discovered if not explicitly wrapped in (double?) quotes.

Not yet sure if an issue with this library (although it seems like it could improve in this regard, too) or the mf2/mf2 parser, which I'm including, too ...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at discoverWebmentionEndpoint and reproduce the reported case, then inspect how the included mf2 parser handles an unquoted href. Confirm whether the library or parser is responsible; done means the endpoint is discovered for valid unquoted HTML, with coverage for the case.

Written by the indexing model from the issue text.

Assessment

Tech stack
html, php
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.