indieweb / indieweb/mention-client-php
findOutgoingLinks method should return only URLs in <a> tags
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 105
- Forks
- 22
- PR merge metrics
- No merged PRs in 30d
Description
Currently the `findOutgoingLinks` method will return any mf2 property that is a URL, regardless of the element the value came from. For example, `` will be considered a link, even though according to HTML it is not a link. This is a problem because sending a webmention to that URL will fail when its webmention endpoint tries to look for a link back.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the findOutgoingLinks method in the mention-client-php codebase and inspect how it extracts URL-valued microformats properties. Reproduce the issue with the provided data element example, then verify that only URLs from a elements are returned while URLs from other elements are excluded.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html, php
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100