indieweb / indieweb/indiewebify-me
"Check your homepage h-card" doesn't pick up u-photo unless it's nested directly under the h-card tag
Nobody has claimed this yet.
- Dominant language
- CSS
- Stars
- 188
- Forks
- 26
- PR merge metrics
- No merged PRs in 30d
Description
[IndieWeb IRC chat](https://chat.indieweb.org/dev/2020-09-04#t1599198130186700) for reference.
I have my u-photo nested two or three `div`s under the `h-card` `div`. This causes IndieWebify.me to not pick up my photo.
When I added a hidden image directly underneath the `h-card` tag, IndieWebify was able to parse it.
The expectation is that no matter how far nested the u-photo or any property is, it should be parsed and picked up.You may see the [current source HTML on my site](https://rusingh.com/).
This is a behaviour that is also mimicked by [Indieweb Webring](https://github.com/martymcguire/indiewebring.ws/) and [a similar issue has been filed](https://github.com/martymcguire/indiewebring.ws/issues/6).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the h-card property parser and reproduce the issue using the current source HTML linked in the report. Verify that a u-photo nested two or three divs under the h-card is detected, and that the existing direct-child case continues to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100