indice-co / indice-co/EDI.Net

EdiSerializer::DeserializeInternal use of reader before null check

Open
#281 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
490
Forks
173
PR merge metrics
No merged PRs in 30d

Description

SuppressBadEscapeSequenceErrors is set before the subsequent check for NULL on the reader.

This fix also includes a little cleanup of things like misspelled comments. 😄

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at EdiSerializer::DeserializeInternal and inspect the order of operations around SuppressBadEscapeSequenceErrors and the reader null check. Confirm the fix prevents reader use before validation, then review the nearby comments for the noted spelling cleanup and verify the existing serializer behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.