indice-co / indice-co/EDI.Net

Optional EdiValue segments in segment group generate empty lines

Open
#151 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C#
Stars
490
Forks
173
PR merge metrics
No merged PRs in 30d

Description

Hello! I have an issue with serializer when defining segments in segment groups like this:
```csharp
[EdiSegmentGroup(.....)]
public class SG
{
...

[EdiValue("X(100)", Path = "FTX/0")]
public string Aaa { get; set; }

public LOC Bbb { get; set; }

...
}
```
Both properties are nulls (they are optional) and they must not be in the EDI document, but I get line `FTX+'` instead. This can be fixed by moving `Aaa` to separate segment class similar to `Bbb`, but it's just excess code in my case. I want to keep those optional single-parameter segments in segment group class.
Is this by design?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the serializer behavior with a segment group containing nullable Aaa and Bbb properties, as shown in the issue. Trace the segment-group serialization entry point and compare single-parameter EdiValue handling with the LOC property; done means optional null segments are omitted rather than producing an empty FTX line.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.